Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: launching activity defined with fully qualified name #2269

Merged
merged 1 commit into from
Jan 19, 2024
Merged

fix: launching activity defined with fully qualified name #2269

merged 1 commit into from
Jan 19, 2024

Conversation

thymikee
Copy link
Member

Summary:

Take into account that activity may be defined as fully qualified name.

Fixes #2268

Test Plan:

Added a unit test

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@thymikee thymikee requested a review from cortinico as a code owner January 19, 2024 16:11
@thymikee thymikee mentioned this pull request Jan 19, 2024
Closed
Titozzz
Titozzz approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@Titozzz Titozzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested !

@thymikee thymikee merged commit c4ffc06 into main Jan 19, 2024
10 checks passed
@thymikee thymikee deleted the fix/activity-launch branch January 19, 2024 19:51
tido64 pushed a commit to tido64/react-native-cli that referenced this pull request Jan 31, 2024
@thymikee @tido64
fix: launching activity defined with fully qualified name (react-nati…
764760e 
…ve-community#2269)
@tido64 tido64 mentioned this pull request Jan 31, 2024
Merged
2 tasks
thymikee added a commit that referenced this pull request Jan 31, 2024
@tido64 @thymikee
fix: launching activity defined with fully qualified name (#2269) (#2283
da7b6ac 
)

Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
@eidan66 eidan66 mentioned this pull request Apr 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Titozzz Titozzz Titozzz approved these changes

@tido64 tido64 tido64 approved these changes

@cortinico cortinico cortinico approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Android: run-android fails with Activity class {...} does not exist
4 participants
@thymikee @cortinico @tido64 @Titozzz